luwei16 commented on PR #68138:
URL: https://github.com/apache/doris/pull/68138#issuecomment-5724442751
Local review result: **PASS**.
Reviewed the exact three-dot diff for head
`e192f752ecf3f665bc298dd5103aadfcedb65267` against live base
`befa4fda0a222f639770567ee3ac691b11ecc33f`, plus compatibility with current
master `102f69734a26a97ebd88bd0bc90c627173046bb1`.
- Goal and scope: the change closes the stale-empty window for direct Cloud
incremental reads by refreshing cached-empty/unknown partitions from
MetaService before empty-partition pruning.
- Correctness and lifecycle: the time-based visibility fence completes
before planning; cached non-empty versions are safe because partition versions
are monotonic; refreshed and cached results are returned in the original
partition order; final scan-node planning still fetches exact execution
versions.
- Concurrency: the PR adds no shared mutable state. The existing RPC/cache
path performs network work before ordered version locks and applies monotonic
cache updates, with no new lock-order or race issue found.
- Parallel paths and compatibility: normal reads, non-Cloud reads, Cloud
table streams, fixed-version wrappers, and time-travel semantics retain their
required behavior. The PR merges cleanly with current master and introduces no
protocol, persistence, or configuration compatibility change.
- Tests and CI: the three new rule tests and the existing final-version
refresh test passed in remote FE UT; compile, style, regression, and
performance checks passed. The separate FE coverage failure is an
infrastructure Maven download failure before `build.sh --fe` started.
- Nit: the new pre-pruning MetaService lookup bypasses
`SummaryProfile.incGetPartitionVersionByHasDataCount()`, so Query Profile
undercounts the hasData/empty-prune reason by one RPC. Total RPC count/time and
query correctness remain accurate.
Findings: Blocker 0, Major 0, Minor 0, Nit 1. The review converged in one
round. This was a read-only review; no local build or test was run.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68138
commit: e192f752ecf3f665bc298dd5103aadfcedb65267
base: befa4fda0a222f639770567ee3ac691b11ecc33f
reviewed_at: 2026-09-18T10:52:43+08:00
reviewer: luwei16
model: gpt-5.6-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 1}
rounds: 1
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
