Gabriel39 opened a new pull request, #68150:
URL: https://github.com/apache/doris/pull/68150

   ### What problem does this PR solve?
   
   Two external regression cases can report empty result mismatches without 
first confirming that the preceding operation succeeded.
   
   In `test_iceberg_deletion_vector`, the Trino container is restarted before 
the comparison query. The test previously retried the data query while ignoring 
command failures, so a startup or query error with empty stdout became a row 
mismatch. Wait for a successful `SELECT 1` with a bounded startup deadline, 
then require the comparison command to succeed before checking its rows. Report 
stdout and stderr on failure, and keep successful empty or incorrect results as 
assertion failures.
   
   In `test_s3_tvf_number_range`, the HDFS Broker Load waiter previously 
returned normally after cancellation or roughly ten seconds of polling. The 
caller could then query a freshly truncated table before loading completed. 
Wait up to 120 seconds using a monotonic clock, return only on `FINISHED`, and 
fail on cancellation or timeout with the job label and last `SHOW LOAD` result.
   
   ### Release note
   
   None. Regression-test changes only.
   
   ### Check List (For Author)
   
   - Test: Both modified suites compile with Groovy 4.0.19; `git diff --check` 
passes. A local harness evaluates the actual modified control-flow blocks with 
simulated command/load responses and virtualized waiting. All eight scenarios 
pass: delayed load completion, cancellation, timeout, missing load job, delayed 
Trino readiness, comparison-command failure, readiness timeout, and a 
successful query returning no rows. The original implementation fails these 
checks. Full external integration execution remains pending CI.
   - Behavior changed: Test startup/load failures now report their execution 
status before row comparison; expected data results are unchanged.
   - Does this need documentation: No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to