luwei16 commented on PR #67820:
URL: https://github.com/apache/doris/pull/67820#issuecomment-5713400265
Review conclusion: **PASS** for `fc4f996920282b095a09313ba2eac18d32ab00a4`.
No Blocker or Major findings remain after two review rounds. The earlier
concerns about `KV_TXN_MAYBE_COMMITTED`, using the maximum end TSO across
queried tables, and waiting selected ordinary-scan partitions were rechecked
and are conservative/safe behaviors rather than correctness blockers.
One non-blocking Minor remains: the final Meta Service lazy-commit wait
follows the version-RPC timeout rather than strictly sharing
`change_visible_timeout_ms`, and eventual mode may still wait at this stage.
This can increase latency for a slow lazy commit but does not cause incorrect
results; it can be handled separately.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67820
commit: fc4f996920282b095a09313ba2eac18d32ab00a4
base: c4dee4bd5e82c6f0f380e0243cbaf265999e6a6a
reviewed_at: 2026-09-17T19:12:19+08:00
reviewer: luwei16
model: gpt-5.6-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 2
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
