mrhhsg commented on PR #67140:
URL: https://github.com/apache/doris/pull/67140#issuecomment-5694826989

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#67140
   commit: 7d172fc7fcca0976466ef044672014b92b271d1b
   base: 4d7a207363b4bf75b4e200ea35d2b5e2bbc54257
   reviewed_at: 2026-09-16T16:59+08:00
   reviewer: mrhhsg
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`be/src/exec/operator/streaming_aggregation_operator.cpp:359-375`:pass-through 
不再收紧 TopN heap;新增 mixed-block/recovery UT 静态检查能够覆盖此前重复候选问题。
   - 
`be/src/exec/operator/distinct_streaming_aggregation_operator.cpp:204-205`:已有 
thread r3860482275 的永久 latch 性能限制仍存在;DYNAMIC hard-limit 的临时预算下降并不必然伴随 
low-memory,预算恢复后 distinct 仍不会恢复预去重。本轮不重复报告该已知问题。
   - `be/src/exec/operator/streaming_agg_memory_limit.h:43-62`:这是 block 
边界的预聚合阈值,不是逐 allocation 的硬内存上限;已有 aggregate-owned heap / serialization scratch 
计量限制仍在。
   - 本轮为 static-only review,覆盖 8/8 changed files,纯文本 header-hygiene 
检查通过;未运行编译、UT、回归或 benchmark,也未将历史测试结果当作本轮验证。
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to