HappenLee commented on PR #67762: URL: https://github.com/apache/doris/pull/67762#issuecomment-5694277042
/review Please review the full updated PR at ecb0efed537d5d3ce47edee938964a1446b6b17f, especially reuse of the original Workload Group scan scheduler, asynchronous completion, request lifetime, exception handling, and shutdown/cancellation behavior. Please revisit the earlier findings against the current code and check for remaining correctness and test-coverage gaps. Validation: 33 BE ASAN unit tests passed. SQL regression, cold-cache storage integration, and performance benchmarks have not been run. As discussed in the existing thread, changes to the shared cloud::bthread_fork_join helper are deferred to a separate follow-up PR; this internal read path no longer calls it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
