wyxxxcat opened a new pull request, #68005:
URL: https://github.com/apache/doris/pull/68005
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Previously, RecyclerMetricsContext used a separate scan pass
(scan_and_statistics_*) to count how many KV keys needed recycling,
which required a full extra KV scan on top of the actual recycle pass.
This was wasteful and added latency.
This commit redesigns the metrics system:
- Introduce MetricValue inner class with MetricType enum inside
RecyclerMetricsContext. MetricValue auto-pushes to the corresponding
bvar on every += / ++ update, so no explicit report() / finish_report()
calls are needed.
- Replace total_recycled_num / total_need_recycle_data_size etc. with
four canonical counters: kv_scanned_num, kv_expired_num,
kv_recycled_num, kv_recycled_bytes. These are updated inline inside
each existing recycle function.
- Remove all scan_and_statistics_* methods (~900 lines) and the
statistics_recycle RPC handler in RecyclerServiceImpl.
- Rename bvars from last_round_* to current_round_*, reflecting that
counters are now live-updated during recycling rather than reported
only after a round completes.
- Remove the HTTP endpoint and config flags that served the old
statistics scan path.
Net effect: single scan pass per recycle round, with metrics available
in real time throughout the round rather than only at the end.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
