englefly commented on code in PR #67891:
URL: https://github.com/apache/doris/pull/67891#discussion_r4003146234
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ForeignKeyContext.java:
##########
@@ -52,7 +52,8 @@
public class ForeignKeyContext {
Set<Map<QualifiedColumn, QualifiedColumn>> constraints = new HashSet<>();
Set<QualifiedColumn> foreignKeys = new HashSet<>();
- Set<QualifiedColumn> primaryKeys = new HashSet<>();
+ Set<QualifiedColumn> declaredPrimaryKeys = new HashSet<>();
Review Comment:
如果主键 是多个字段, 这个hashset 有可能把 <A, B> 的主键 看作 两个主键
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ForeignKeyContext.java:
##########
Review Comment:
这个注释不对, join 会expire 主键. 要不要一起更新了?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
