LuciferYang commented on PR #67873: URL: https://github.com/apache/doris/pull/67873#issuecomment-5636683376
Closing as a duplicate: #67848 landed the same change 40 minutes ago (859a19c3a54), and its version is the better one, since `target_sources` avoids repeating the source in both `add_library` branches and the `-Wno-conversion` exemption is guarded by `COMPILER_CLANG`. For whatever it is worth as an independent check, the four-variant table in the description was measured against that same shape and agrees: with `getentropy.c` linked through `glibc-compatibility-explicit`, `getentropy` resolves to Doris' 637-byte definition and the probe runs on glibc 2.17, while all three variants that leave it in the archive crash at pc 0 there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
