github-actions[bot] commented on code in PR #16402:
URL: https://github.com/apache/doris/pull/16402#discussion_r1095519673
##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -754,6 +937,42 @@ Status
ProcessHashTableProbe<JoinOpType>::do_process_with_other_join_conjuncts(
}
}
+// For left or full outer join with other conjuncts.
+// If multiple equal-conjuncts-matched tuples is splitted into several
+// sub blocks, just filter out all the other-conjuncts-NOT-matched tuples at
first,
+// and when processing the last sub block, check whether there are any
+// equal-conjuncts-matched tuple is output in all sub blocks,
+// if not, just pick a tuple and output.
+template <int JoinOpType>
+void ProcessHashTableProbe<JoinOpType>::_process_splited_equal_matched_tuples(
+ int start_row_idx, int row_count, const ColumnPtr& other_hit_column,
+ std::vector<bool*>& visited_map, int right_col_idx, int right_col_len,
+ UInt8* __restrict null_map_data, UInt8* __restrict filter_map, Block*
output_block) {
+ int end_row_idx = start_row_idx + row_count;
+ for (int i = start_row_idx; i < end_row_idx; ++i) {
+ auto join_hit = visited_map[i] != nullptr;
+ auto other_hit = other_hit_column->get_bool(i);
+
+ if (!other_hit) {
+ for (size_t j = 0; j < right_col_len; ++j) {
+ typeid_cast<ColumnNullable*>(
+ std::move(*output_block->get_by_position(j +
right_col_idx).column)
Review Comment:
warning: std::move of the const expression has no effect; remove std::move()
[performance-move-const-arg]
```suggestion
*output_block->get_by_position(j +
right_col_idx).column
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
