HappenLee commented on code in PR #16337:
URL: https://github.com/apache/doris/pull/16337#discussion_r1094664749
##########
fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java:
##########
@@ -325,277 +325,233 @@ private void init(String driverUrl, String sql, int
batchSize, String driverClas
public void copyBatchBooleanResult(Object columnObj, boolean isNullable,
int numRows, long nullMapAddr,
long columnAddr) {
Boolean[] column = (Boolean[]) columnObj;
- byte[] columnData = new byte[numRows];
if (isNullable) {
- byte[] nullMap = new byte[numRows];
for (int i = 0; i < numRows; i++) {
if (column[i] == null) {
- nullMap[i] = 1;
+ UdfUtils.UNSAFE.putByte(nullMapAddr + i, (byte) 1);
Review Comment:
should always putByte. if column[i] != null, put 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
