morrySnow commented on code in PR #62606:
URL: https://github.com/apache/doris/pull/62606#discussion_r3912632457
##########
fe/fe-catalog/src/main/java/org/apache/doris/catalog/Column.java:
##########
@@ -51,11 +51,27 @@ public class Column implements GsonPostProcessable {
public static final String HIDDEN_COLUMN_PREFIX = "__DORIS_";
// all shadow indexes should have this prefix in name
public static final String SHADOW_NAME_PREFIX = "__doris_shadow_";
+ public static final String IVM_HIDDEN_COLUMN_PREFIX = "__DORIS_IVM_";
// NOTE: you should name hidden column start with '__DORIS_'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
public static final String DELETE_SIGN = "__DORIS_DELETE_SIGN__";
public static final String WHERE_SIGN = "__DORIS_WHERE_SIGN__";
public static final String SEQUENCE_COL = "__DORIS_SEQUENCE_COL__";
public static final String GLOBAL_ROWID_COL = "__DORIS_GLOBAL_ROWID_COL__";
+ public static final String IVM_ROW_ID_COL = "__DORIS_IVM_ROW_ID_COL__";
+ public static final String IVM_AGG_COUNT_COL =
"__DORIS_IVM_AGG_COUNT_COL__";
+ public static final String IVM_DML_FACTOR_COL =
"__DORIS_IVM_DML_FACTOR_COL__";
+ public static final String IVM_BASE_OP_COL = "__DORIS_IVM_BASE_OP_COL__";
Review Comment:
使用 IVM_HIDDEN_COLUMN_PREFIX 变量作为前缀
##########
fe/fe-catalog/src/main/java/org/apache/doris/catalog/Column.java:
##########
@@ -285,6 +301,7 @@ public Column(String name, Type type, boolean isKey,
AggregateType aggregateType
false, null, null, Sets.newHashSet(), null);
}
+
Review Comment:
多余的空行
##########
fe/fe-catalog/src/main/java/org/apache/doris/catalog/Column.java:
##########
@@ -51,11 +51,27 @@ public class Column implements GsonPostProcessable {
public static final String HIDDEN_COLUMN_PREFIX = "__DORIS_";
// all shadow indexes should have this prefix in name
public static final String SHADOW_NAME_PREFIX = "__doris_shadow_";
+ public static final String IVM_HIDDEN_COLUMN_PREFIX = "__DORIS_IVM_";
// NOTE: you should name hidden column start with '__DORIS_'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
public static final String DELETE_SIGN = "__DORIS_DELETE_SIGN__";
public static final String WHERE_SIGN = "__DORIS_WHERE_SIGN__";
public static final String SEQUENCE_COL = "__DORIS_SEQUENCE_COL__";
public static final String GLOBAL_ROWID_COL = "__DORIS_GLOBAL_ROWID_COL__";
+ public static final String IVM_ROW_ID_COL = "__DORIS_IVM_ROW_ID_COL__";
+ public static final String IVM_AGG_COUNT_COL =
"__DORIS_IVM_AGG_COUNT_COL__";
+ public static final String IVM_DML_FACTOR_COL =
"__DORIS_IVM_DML_FACTOR_COL__";
+ public static final String IVM_BASE_OP_COL = "__DORIS_IVM_BASE_OP_COL__";
+ public static final String IVM_DELTA_GROUP_COUNT_COL =
"__DORIS_IVM_DELTA_GROUP_COUNT_COL__";
+ // Prefix for sink-level IVM identity key hidden columns
(__DORIS_IVM_KEY_).
+ public static final String IVM_KEY_COL_PREFIX = IVM_HIDDEN_COLUMN_PREFIX +
"KEY_";
+ // Prefix for union arm-index columns (__DORIS_IVM_UNION_ARM_INDEX_).
+ public static final String IVM_UNION_ARM_INDEX_COL_PREFIX =
IVM_HIDDEN_COLUMN_PREFIX + "UNION_ARM_INDEX_";
+ // Prefix for union positional key columns (__DORIS_IVM_UNION_KEY_).
+ public static final String IVM_UNION_KEY_COL_PREFIX =
IVM_HIDDEN_COLUMN_PREFIX + "UNION_KEY_";
+ // Suffix for the renamed base-table row-id column
(__DORIS_IVM_{n}_ROW_ID_COL__), using the
+ // standard IVM hidden-column prefix. Kept as an identity key when a
cascading MV with only
+ // row-id keys is scanned under a join.
+ public static final String IVM_BASE_ROW_ID_COL_SUFFIX = "_ROW_ID_COL__";
Review Comment:
这个和 IVM_ROW_ID_COL 感觉可以merge merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
