gavinchou commented on code in PR #67486:
URL: https://github.com/apache/doris/pull/67486#discussion_r3923148541
##########
cloud/src/meta-service/meta_service_partition.cpp:
##########
@@ -1214,7 +1214,9 @@ void
MetaServiceImpl::commit_table_stream_partition_internal(
auto source_version_it = stream_versions.find(partition_id);
DCHECK(source_version_it != stream_versions.end());
const VersionPB& source_version = source_version_it->second;
- if (offset.offset_tso() > source_version.commit_tso()) {
+ // Water marks use next-point semantics (real commit_tso + 1); the
initial offset may
+ // legally reach source commit_tso + 1. The empty-partition sentinel
(-1) always passes.
+ if (offset.offset_tso() > source_version.commit_tso() + 1) {
Review Comment:
why not persist `source_version.commit_tso() + 1` as the next start offset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
