github-actions[bot] commented on code in PR #67468: URL: https://github.com/apache/doris/pull/67468#discussion_r3921177641
########## be/src/storage/segment/vertical_segment_writer.cpp: ########## @@ -17,50 +17,49 @@ #include "storage/segment/vertical_segment_writer.h" -#include <crc32c/crc32c.h> -#include <gen_cpp/olap_file.pb.h> +#include <assert.h> #include <gen_cpp/segment_v2.pb.h> #include <parallel_hashmap/phmap.h> #include <algorithm> -#include <cassert> -#include <memory> -#include <ostream> -#include <string> -#include <unordered_map> -#include <utility> +#include <numeric> + +// IWYU pragma: no_include <opentelemetry/common/threadlocal.h> Review Comment: [P1] Exclude finalized key-index bytes from value-group capacity checks In a multi-group vertical compaction, the key group is finalized before each value group, but clear() leaves _primary_key_index_builder/_short_key_index_builder populated. The new _finalize_columns_data() calls estimate_segment_size() for the value group, and _key_index_size() adds those already-written key-index bytes to the incoming size. Near the flood threshold this can return DISK_REACH_CAPACITY_LIMIT even when the value-group buffers fit. Please exclude finalized key-index state for has_key == false (or reset/snapshot it) before this capacity check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
