deardeng opened a new pull request, #67464:
URL: https://github.com/apache/doris/pull/67464
Problem:
Peer reads create an uncached BRPC client for every request. When a peer is
unreachable, readers across tablets repeatedly connect to the same address with
the default 2-second connect timeout and 10 retries.
Impact:
An unavailable cache peer can repeatedly delay reads before remote-storage
fallback and generate unnecessary connection attempts and warning logs.
Fix:
- Add a BE-wide, address-level circuit breaker shared by peer readers.
- Open the circuit after a configurable number of consecutive connection or
RPC failures (3 by default) for a configurable cooldown (30 seconds by default).
- Reject reads while the circuit is open, allow one probe after cooldown,
and clear the failure state after a successful RPC.
- Make uncached BRPC connect timeout and retry count configurable at the
call site, and use a 200 ms timeout with no retries for peer reads.
Test:
Stop the peer test server and verify that four reads issue only three RPC
attempts, with the final read rejected by the circuit breaker.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
