gavinchou commented on code in PR #67456:
URL: https://github.com/apache/doris/pull/67456#discussion_r3916685858
##########
gensrc/proto/olap_file.proto:
##########
@@ -155,10 +163,7 @@ message RowsetMetaPB {
optional bool segments_key_bounds_aggregated = 57;
optional bool is_row_binlog = 58 [default = false];
-
- // Valid only when segments_overlap_pb is NONOVERLAPPING_WITHIN_GROUP.
- // Each value is the number of consecutive output segments in one
non-overlapping group.
- repeated int32 segment_group_sizes = 59;
+ optional PRowBinlogWriteColumnMappings row_binlog_column_mappings = 59;
Review Comment:
I don't think we need to persist column mapping in rowset meta, because it
is only used in a context that FE can always generate a plan with the column
mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
