Gabriel39 commented on PR #67201: URL: https://github.com/apache/doris/pull/67201#issuecomment-5490117556
[P2] Please validate blank Lance index names in both the CREATE and DROP paths. Nereids still accepts empty backquoted identifiers outside the specialized column-path validation (for example, `CREATE INDEX `` ...` and `DROP INDEX `` ...`). `validateCreateIndex` currently checks only whether the UTF-8 name exceeds 64 bytes, so an empty name passes. For Directory DROP, `AlterTableCommand` returns the typed unsupported error before `DropIndexOp.validate()` runs, bypassing its existing `StringUtils.isEmpty(indexName)` check and providing no 64-byte bound. In the current reject-all stage this masks malformed SQL as an unsupported operation. More importantly, if the follow-up admission path reuses this validator, an empty logical name could reach the durable job and same-name fence. Please add a shared Lance index-name validator that rejects null/empty names and names over 64 UTF-8 bytes, invoke it for Directory CREATE and DROP, and add command-level coverage for empty quoted names. The REST path can retain its fail-fast unsupported response before database/table metadata resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
