jackwener commented on code in PR #15264:
URL: https://github.com/apache/doris/pull/15264#discussion_r1091492835


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/JoinOrderJob.java:
##########
@@ -94,33 +93,16 @@ private Group optimizeJoin(Group group) {
             }
         }
         Group optimized = planReceiver.getBestPlan(hyperGraph.getNodesMap());
-        Group memoRoot = copyToMemo(optimized);
 
         // For other projects, such as project constant or project nullable, 
we construct a new project above root
         if (otherProject.size() != 0) {
-            
otherProject.addAll(memoRoot.getLogicalExpression().getPlan().getOutput());
+            
otherProject.addAll(optimized.getLogicalExpression().getPlan().getOutput());

Review Comment:
   next PR, we can rename `optimized` -> `optimizedGroup`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to