morrySnow commented on code in PR #66968:
URL: https://github.com/apache/doris/pull/66968#discussion_r3877828923
##########
fe/fe-sql-parser/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1648,7 +1682,9 @@ lambdaExpression
| LEFT_PAREN
args+=errorCapturingIdentifier (COMMA args+=errorCapturingIdentifier)+
RIGHT_PAREN
- ARROW body=booleanExpression
+ ARROW ({isTupleLambdaBody()}?
Review Comment:
这个 `{isTupleLambdaBody()}?` 做过 benchmark 吗？确定可以提升性能吗？
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -763,8 +763,6 @@ public class Rewriter extends AbstractBatchJobExecutor {
new MergePercentileToArray())
),
topic("add projection for volatile expression",
- // separate AddProjectForVolatileExpression and
MergeProjectable
- // to avoid dead loop if code has bug
Review Comment:
这个不要删
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/ExpressionAnalyzer.java:
##########
@@ -144,6 +153,14 @@ protected Expression
processCompoundNewChildren(CompoundPredicate cp, List<Expre
}
};
+ private static final Set<String> MAP_ENTRY_LAMBDA_FUNCTIONS =
ImmutableSet.of(
+ "map_all",
+ "map_apply",
+ "map_exists",
+ "map_filter",
+ "transform_keys",
+ "transform_values");
Review Comment:
这个list，包括下面的 bindMapLambdaFunction
可以重构以更适合扩展，参考：https://github.com/apache/doris/pull/67284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
