hubgeter commented on code in PR #66546: URL: https://github.com/apache/doris/pull/66546#discussion_r3877758816
########## thirdparty/arrow-paimon-vars.sh: ########## @@ -21,12 +21,24 @@ # Keep the Arrow/Paimon source closure in a dedicated file so targeted CI can # distinguish this stack from unrelated thirdparty changes. -# arrow +# Arrow 24 is installed in a versioned prefix. The unversioned install prefix is Review Comment: Confirmed against the live `apache/branch-4.1` head `aa135178aaf1`. The current consumer still validates the shared automation archive at the unversioned `installed` root in `run-be-ut.sh` / `thirdparty/arrow-paimon-vars.sh`, and BE imports that same root via `THIRDPARTY_DIR`. Therefore this P1 is valid: a master-only change cannot make one fixed unversioned path expose Arrow/Paimon 17 to pre-backport revisions and Arrow/Paimon 24 to the current branch at the same time. The dual-layout artifact must not be published until a companion branch-4.1 consumer change selects `installed/arrow-24.0.0`. I intentionally did not add an ABI-mixed shim or hide the rollout dependency in this PR, and I am leaving this thread unresolved until that branch change is authorized and landed. For the code in this PR, the rebase onto current master is now at `cf4a25729ff`; the focused lifecycle test, shell syntax checks, and formatting checks pass. The prior-head TeamCity Compile, BE UT, and Performance builds also passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
