github-actions[bot] commented on code in PR #67158: URL: https://github.com/apache/doris/pull/67158#discussion_r3877633656
########## thirdparty/test/adbc-jni-config-test.sh: ########## @@ -0,0 +1,35 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -euo pipefail + +ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." &>/dev/null && pwd)" +EXTERNAL_FE_CONF="${ROOT}/regression-test/pipeline/external/conf/fe.conf" +# shellcheck disable=SC2016 # Match the literal option before fe.conf expands DORIS_HOME. +JNI_LIBRARY_OPTION='-Darrow.adbc.driver.jni.library.path=${DORIS_HOME}/lib' + +# External Regression replaces the packaged FE configuration instead of merging it. +# Keep the JNI override in that replacement so ADBC cannot fall back to the jar binary. +java_opts_assignment="$(grep '^JAVA_OPTS_FOR_JDK_17=' "${EXTERNAL_FE_CONF}" || true)" Review Comment: [P2] Validate the runtime-effective JDK-17 assignment `grep` returns every active `JAVA_OPTS_FOR_JDK_17` assignment, so an earlier correct line can satisfy this check even after a later definition overrides it without the JNI option. `start_fe.sh` exports these assignments sequentially, making the later value effective; with the current line followed by `JAVA_OPTS_FOR_JDK_17="-Xmx4096m"`, this script still reports `PASS` while FE lacks the override and can fall back to the Maven-bundled JNI library. Please validate the effective final assignment (or reject duplicates) and add that later-override negative case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
