yiguolei commented on code in PR #67236:
URL: https://github.com/apache/doris/pull/67236#discussion_r3874225269
##########
be/src/exec/pipeline/pipeline_fragment_context.h:
##########
@@ -230,6 +230,9 @@ class PipelineFragmentContext : public TaskExecutionContext
{
// After prepared, `_total_tasks` is equal to the size of `_tasks`.
// When submit fail, `_total_tasks` is equal to the number of tasks
submitted.
std::atomic<int> _total_tasks = 0;
+ // Multiple tasks can observe the same query cancellation and call cancel
concurrently.
+ // Run fragment-level cancellation side effects only once.
+ std::atomic_bool _cancelled = false;
Review Comment:
不要增加这种标记位
一个fragment的status 是由atomic status 这种来标记的。
单独的标记位，会引入问题，比如is cancelld，然后，后面可能还会增加一个string 来存储reason 这种东东
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
