CalvinKirs commented on code in PR #67186:
URL: https://github.com/apache/doris/pull/67186#discussion_r3869441028
##########
fe/fe-connector/fe-connector-spi/src/test/java/org/apache/doris/connector/spi/ConnectorPluginSurfaceTest.java:
##########
@@ -73,8 +73,9 @@ public void connectorApiMajorTracksTheRecordedSurfaceChange()
throws IOException
Assertions.assertNotNull(in, "missing connector plugin API version
resource");
version.load(in);
}
- // Write binding gained execution-capability methods in this surface
revision. A plugin built against
- // major 5 must be refused rather than run against a contract it did
not compile against.
+ // Write binding gained execution-capability methods, while metadata
access gained operation control,
Review Comment:
Thanks for calling this out. We intentionally will not bump the connector
SPI to 7.0 in this PR. The compatibility boundary should be a published
connector API version, not every PR that evolves an API which is still
unreleased on master. Connector SPI 6.0 was introduced on master on Aug 17,
2026, and no release tag contains that commit, so 6.0 is still the next
unpublished surface; this PR updates that same pre-release surface and its
frozen baseline before publication. Once 6.0 is released, a subsequent
incompatible surface change must bump the major. Bumping the major once per
pre-release PR would consume versions without creating a real artifact
compatibility boundary. The existing major gate still correctly separates
published/older major 5 plugins from the upcoming major 6 API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
