AntiTopQuark commented on code in PR #66191:
URL: https://github.com/apache/doris/pull/66191#discussion_r3868724859
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/TabletMeta.java:
##########
@@ -34,9 +34,15 @@ public class TabletMeta {
private int newSchemaHash;
private TStorageMedium storageMedium;
+ private final boolean isRowBinlog;
public TabletMeta(long dbId, long tableId, long partitionId, long indexId,
int schemaHash,
Review Comment:
Fixed as suggested: removed the six-argument `TabletMeta` constructor that
defaulted `isRowBinlog=false`, so all call sites must now explicitly pass the
tablet role. The ordinary tablet creation path passes `false /* isRowBinlog
*/`, while the index-aware creation, recovery, and metadata rebuild paths pass
`index.isRowBinlog()` or `indexMeta.isRowBinlogIndex()`, avoiding silent
misclassification during upgrade or replay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
