Gabriel39 commented on code in PR #67166:
URL: https://github.com/apache/doris/pull/67166#discussion_r3862439968
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/connector/converter/ConnectorColumnConverter.java:
##########
@@ -238,7 +238,7 @@ public static ConnectorType toConnectorType(Type dorisType)
{
// isCommentSpecified() so the diff can tell an omitted COMMENT
(preserve the current doc) from
// COMMENT '' (clear it) — the comment string is "" for both
(#65329 omit-preserves-metadata).
for (StructField f : struct.getFields()) {
- names.add(f.getName());
+ names.add(f.getOriginalName());
Review Comment:
Fixed. Existing struct fields are now matched case-insensitively while every
update uses the existing Iceberg field path, so only the dedicated rename
operation can change persisted spelling. Appended-field collision checks are
also case-insensitive. Added InMemoryCatalog regression coverage for type,
comment, and nullability changes, ARRAY/MAP nesting, and duplicate-case
collisions.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/StructField.java:
##########
@@ -49,7 +50,13 @@ public StructField(String name, DataType dataType, boolean
nullable, String comm
public StructField(String name, DataType dataType, boolean nullable,
String comment,
boolean commentSpecified) {
+ this(name, name, dataType, nullable, comment, commentSpecified);
+ }
+
+ public StructField(String name, String originalName, DataType dataType,
boolean nullable, String comment,
Review Comment:
Fixed. Added Javadoc that documents the normalized runtime name versus
preserved external schema spelling contract. The CI-equivalent `mvn clean
checkstyle:check` now passes across all 74 FE modules with zero violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
