github-actions[bot] commented on code in PR #67158:
URL: https://github.com/apache/doris/pull/67158#discussion_r3860628864
##########
thirdparty/patches/paimon-cpp-buildutils-static-deps.patch:
##########
@@ -343,3 +343,19 @@ diff --git a/src/paimon/format/blob/blob_format_writer.cpp
b/src/paimon/format/b
+ list(GET Thrift_VERSION_LIST 0 Thrift_VERSION_MAJOR)
+ list(GET Thrift_VERSION_LIST 1 Thrift_VERSION_MINOR)
+ list(GET Thrift_VERSION_LIST 2 Thrift_VERSION_PATCH)
+
+diff --git a/src/paimon/CMakeLists.txt b/src/paimon/CMakeLists.txt
+index 76dd03b..9317324 100644
+--- a/src/paimon/CMakeLists.txt
++++ b/src/paimon/CMakeLists.txt
+@@ -281,6 +281,10 @@ add_paimon_lib(paimon
+ ${PAIMON_COMMON_SRCS}
+ ${PAIMON_CORE_SRCS}
+ DEPENDENCIES
++ # Codec headers come from ExternalProject install steps, so
object
++ # compilation must not race those steps in clean parallel
builds.
++ zstd
++ snappy
Review Comment:
[P1] Add the LZ4 install edge to this object-library fence
In Doris's `PAIMON_USE_EXTERNAL_ARROW=ON` path,
`block_compression_factory.cpp` is part of `PAIMON_COMMON_SRCS` and reaches
headers that directly include `<lz4.h>`. `build_lz4()` installs that header
through `lz4_ep`, but the external imported `arrow` target has no dependency
that orders `lz4_ep` before `paimon_objlib`. The generated Ninja object-order
edge after this change waits for `zstd_ep` and `snappy_ep`, but not `lz4_ep`,
so a clean parallel build can still start this object library before `lz4.h`
exists and fail with the same class of missing-header error. Please add `lz4`
to `DEPENDENCIES` and extend the focused test to assert it (or query the real
external-Arrow graph).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
