deardeng commented on code in PR #66191:
URL: https://github.com/apache/doris/pull/66191#discussion_r3850646516
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/TabletMeta.java:
##########
@@ -34,9 +34,15 @@ public class TabletMeta {
private int newSchemaHash;
private TStorageMedium storageMedium;
+ private final boolean isRowBinlog;
public TabletMeta(long dbId, long tableId, long partitionId, long indexId,
int schemaHash,
Review Comment:
Could we remove the six-argument TabletMeta constructor that silently
defaults isRowBinlog to false and require every call site to pass the tablet
role explicitly?
There are a limited number of production call sites, and making the role
mandatory would turn future omissions in restore/replay/rebuild paths into an
explicit review decision instead of silently misclassifying a row-binlog
tablet. Call sites that are guaranteed to create ordinary tablets can pass
false /* isRowBinlog */, while index-aware paths should pass
index.isRowBinlog() or indexMeta.isRowBinlogIndex().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
