mrhhsg opened a new pull request, #67070:
URL: https://github.com/apache/doris/pull/67070
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
The ThreadPool scan scheduler submitted one runnable per scanner and
serialized scheduling through a scheduler-wide lock. With many scanners, this
inflated queue occupancy and coupled ThreadPool admission to
TaskExecutor-specific scheduling logic.
This change queues at most one runnable per `ScannerContext`, admits scanner
tasks under the Context transfer lock, keeps ThreadPool submission failures
local to the Context scheduler, and checks terminal Context state before
rescheduling. TaskExecutor remains the default scan scheduler, and this change
does not modify generic ThreadPool behavior.
Validation:
- `./run-be-ut.sh --run --filter='ScannerContextTest.*' -j16` (35 tests
passed)
- `./run-be-ut.sh --run --filter='ThreadPoolTest.*' -j16` (18 tests passed)
- `./build-support/check-format.sh`
- `./build-support/check-build-hygiene.sh`
- `git diff --check`
`run-clang-tidy.sh` was also attempted, but the local clang-tidy environment
cannot analyze the files because the configured toolchain cannot find
`stddef.h` and current `be/src/core/types.h` reports a pre-existing unmatched
`NOLINTEND`.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. The opt-in ThreadPool scan scheduler queues and admits work
per `ScannerContext`.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
