github-actions[bot] commented on PR #16175:
URL: https://github.com/apache/doris/pull/16175#issuecomment-1407439030
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4032713862";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/custom_settings.sh line 23:
CONTAINER_UID="doris--"
^-----------^ SC2034 (warning): CONTAINER_UID appears unused. Verify use (or
export if used externally).
In docker/thirdparties/run-thirdparties-docker.sh line 116:
COMPONENTS=`echo "${COMPONENTS}" | sed 's/ //g'`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^-- SC2001 (style): See if you can use
${variable//search/replace} instead.
Did you mean:
COMPONENTS=$(echo "${COMPONENTS}" | sed 's/ //g')
In docker/thirdparties/run-thirdparties-docker.sh line 121:
COMPONENTS_ARR=(${COMPONENTS//,/ })
^----------------^ SC2206 (warning): Quote to prevent word
splitting/globbing, or split robustly with mapfile or read -a.
In docker/thirdparties/run-thirdparties-docker.sh line 130:
for element in ${COMPONENTS_ARR[@]}; do
^------------------^ SC2068 (error): Double quote array
expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to
...
https://www.shellcheck.net/wiki/SC2034 -- CONTAINER_UID appears unused.
Ver...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word
splitting/g...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- docker/thirdparties/run-thirdparties-docker.sh.orig
+++ docker/thirdparties/run-thirdparties-docker.sh
@@ -113,7 +113,7 @@
exit 1
fi
-COMPONENTS=`echo "${COMPONENTS}" | sed 's/ //g'`
+COMPONENTS=$(echo "${COMPONENTS}" | sed 's/ //g')
echo "Components are: ${COMPONENTS}"
echo "Container UID: ${CONTAINER_UID}"
echo "Stop: ${STOP}"
@@ -131,9 +131,9 @@
if [[ "${element}"x == "mysql"x ]]; then
RUN_MYSQL=1
elif [[ "${element}"x == "pg"x ]]; then
- RUN_PG=1
+ RUN_PG=1
elif [[ "${element}"x == "oracle"x ]]; then
- RUN_ORACLE=1
+ RUN_ORACLE=1
elif [[ "${element}"x == "sqlserver"x ]]; then
RUN_SQLSERVER=1
elif [[ "${element}"x == "es"x ]]; then
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
