github-actions[bot] commented on code in PR #16084: URL: https://github.com/apache/doris/pull/16084#discussion_r1089774885
########## be/src/runtime/memory/mem_tracker_limiter.cpp: ########## @@ -195,26 +196,35 @@ void MemTrackerLimiter::print_log_usage(const std::string& msg) { } } +std::string MemTrackerLimiter::log_process_usage_str(const std::string& msg, bool with_stacktrace) { + std::string detail = msg; + detail += "\nProcess Memory Summary:\n " + MemTrackerLimiter::process_mem_log_str(); + if (with_stacktrace) detail += "\nAlloc Stacktrace:\n" + get_stack_trace(); Review Comment: warning: statement should be inside braces [readability-braces-around-statements] ```suggestion if (with_stacktrace) { detail += "\nAlloc Stacktrace:\n" + get_stack_trace(); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org