HappenLee commented on code in PR #66788:
URL: https://github.com/apache/doris/pull/66788#discussion_r3794679304
##########
fe/fe-core/src/main/java/org/apache/doris/qe/AutoCloseSessionVariable.java:
##########
@@ -46,7 +46,7 @@ public AutoCloseSessionVariable(ConnectContext
connectContext, Map<String, Strin
previousVariable = connectContext.getSessionVariable();
}
SessionVariable sessionVariable = new SessionVariable();
-
sessionVariable.setAffectQueryResultInPlanSessionVariables(affectQueryResultVariables);
+ sessionVariable.setForwardedSessionVariables(sessionVariables);
Review Comment:
Fixed in ab81cb5013c. AutoCloseSessionVariable is restored exactly to its
pre-PR affectQueryResultInPlan-only behavior. The Broker and Routine Load
session reconstruction added by this PR has also been removed, so those
asynchronous paths retain their historical fresh-TQueryOptions behavior.
Synchronous Stream Load reads the request-scoped ConnectContext snapshot
directly and no longer reuses this class. The two targeted FE test classes
passed all 25 tests, and the full FE build/checkstyle passed.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3513,6 +3515,10 @@ public void
checkAnnIndexCandidateRowsPercentThreshold(String value) {
description = "Enable extended regular expressions, support
look-around zero-width assertions")
public boolean enableExtendedRegex = false;
+ @VarAttrDef.VarAttr(name = ENABLE_HYPERSCAN_FALLBACK, needForward = true,
affectQueryResultInExecution = true,
Review Comment:
Scope update in ab81cb5013c: the earlier asynchronous-load propagation
change has been rolled back. This PR no longer changes Broker or Routine Load
session handling; they keep their historical fresh-TQueryOptions defaults, and
enable_hyperscan_fallback inheritance across those asynchronous job boundaries
is deferred to a separate change. Request-scoped synchronous Stream Load
remains covered without modifying AutoCloseSessionVariable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
