github-actions[bot] commented on code in PR #64160:
URL: https://github.com/apache/doris/pull/64160#discussion_r3793544657
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java:
##########
@@ -728,9 +728,8 @@ public void unregisterExternalTable(String dbName, String
tableName, String cata
tableNameToInvalidate = table.getName();
}
- // All current production callers with ignoreIfExists=true are HMS
event paths. Skip load-through table
- // existence validation so local names/object/ID/engine cache cleanup
still runs after the table has already
- // disappeared remotely. Resolve the event's remote name to the same
canonical local key used by CREATE_TABLE.
+ // Incremental metastore events skip load-through existence validation
because the table may already be
Review Comment:
**[P1] Route mapped event names to the new invalidation barriers**
Event descriptors carry remote identities, but this path calls
`getDbNullable(dbName)` before applying the connector's
`fromRemoteDatabaseName` mapping. For a plugin that combines an event source
with a supported mode-0 mapping such as `RemoteDB -> LocalDB`, the lookup
misses `LocalDB` and returns, so REGISTER/UNREGISTER/RENAME never reaches the
new local object/ID/engine/row-count barriers. Refresh and partition handlers
also use the remote table name directly, so their new row-count fences are
skipped under table mapping. Canonicalize both database and table identities
once at event ingress for FE operations, retain remote names for connector
invalidation, and add mapped-name event tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
