starocean999 commented on code in PR #66681:
URL: https://github.com/apache/doris/pull/66681#discussion_r3781663098
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ProjectOtherJoinConditionForNestedLoopJoin.java:
##########
@@ -114,7 +114,9 @@ public Expression visit(Expression expression,
ReplacerContext ctx) {
// pair" to "per row of that child", which silently changes
results. Keep such
// expressions inline in otherJoinConjuncts, but still recurse to
extract deterministic
// child expressions.
- if (expression.containsVolatileExpression()) {
+ // A NoneMovableFunction (e.g. assert_true) has the same
granularity problem, so it
+ // must stay inline as well.
+ if (expression.containsNoneMovableOrVolatile()) {
return super.visit(expression, ctx);
Review Comment:
minor issue, no need change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
