deardeng commented on code in PR #66751:
URL: https://github.com/apache/doris/pull/66751#discussion_r3780928748
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -627,6 +634,12 @@ private void checkCommitStatus(List<Table> tableList,
TransactionState transacti
throw new
TransactionCommitFailedException("could not find replica for tablet ["
+ tabletId + "], backend [" +
tabletBackend + "]");
}
+ if (!crossAzSuccQuorum.isEmpty()) {
+
backendLocationTags.computeIfAbsent(tabletBackend, backendId -> {
+ Backend backend =
env.getCurrentSystemInfo().getBackend(backendId);
+ return backend == null ? "" :
backend.getLocationTag().value;
Review Comment:
This is intentional feature behavior. Invalid entries are skipped with a
warning, while valid entries remain effective. We do not want one malformed
entry to reject the entire dynamic configuration update.
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -670,6 +683,37 @@ private void checkCommitStatus(List<Table> tableList,
TransactionState transacti
throw new
TabletQuorumFailedException(transactionId, errMsg);
}
+
+ for (Entry<String, Integer> entry :
crossAzSuccQuorum.entrySet()) {
Review Comment:
Fixed in commit 270068ffbab. Backend.locationTag is now published through a
volatile reference, with a regression test covering the required visibility
semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
