github-actions[bot] commented on code in PR #66750:
URL: https://github.com/apache/doris/pull/66750#discussion_r3780636548
##########
fe/fe-connector/fe-connector-paimon/src/main/java/org/apache/doris/connector/paimon/PaimonConnectorProvider.java:
##########
@@ -53,6 +53,13 @@ public Set<String> acceptedCreateTableEngineNames() {
return Collections.singleton("paimon");
}
+ @Override
+ public String displayEngineName() {
+ // System-table diagnostics use this connector-owned name; keep the
canonical product spelling while
+ // catalog routing and CREATE TABLE continue to accept the lowercase
type through their own contracts.
+ return "Paimon";
Review Comment:
**[P1] Regenerate the Paimon SHOW CREATE result**
This value also feeds `PluginDrivenExternalTable.getEngineTableTypeName()`.
Paimon does not provide native SHOW CREATE DDL, so `ShowCreateTableCommand`
falls through to `Env.getDdlStmt`, which will now emit `ENGINE=Paimon`. The
existing generated result
`regression-test/data/external_table_p0/paimon/test_paimon_table_properties.out`
still expects `ENGINE=paimon`, so `test_paimon_table_properties` will fail its
golden comparison whenever the Paimon external suite is enabled. Please run
that suite through the regression runner and commit the regenerated `.out` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
