englefly commented on code in PR #16102:
URL: https://github.com/apache/doris/pull/16102#discussion_r1083228825
##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -334,6 +334,12 @@ struct DateTimeFindOp : public CommonFindOp<DateTimeValue>
{
value.from_olap_datetime(*reinterpret_cast<const uint64_t*>(data));
return bloom_filter.test(Slice((char*)&value, sizeof(DateTimeValue)));
}
+ void insert(BloomFilterAdaptor& bloom_filter, const void* data) const {
Review Comment:
shall we do the unify job of all datatypes in one place? There are other
data types whose storage format are different from their engine format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
