github-actions[bot] commented on code in PR #66711:
URL: https://github.com/apache/doris/pull/66711#discussion_r3773268102
##########
fe/fe-core/src/test/java/org/apache/doris/datasource/paimon/source/PaimonScanNodeTest.java:
##########
@@ -337,6 +338,9 @@ public void testSplitWeight() throws UserException {
Assert.assertEquals(2, s1.size());
Assert.assertEquals(100, s11.getSplitWeight().getRawValue());
Assert.assertNull(s11.getSplit());
+ Assert.assertFalse(s11.getFileAffinityKey().isPresent());
+ SplitAssignment.enableFileAffinity(Collections.singletonList(s11),
true);
+ Assert.assertTrue(s11.getFileAffinityKey().isPresent());
Review Comment:
[P1] Exercise an actually split Paimon file
This fixture resolves a 64 MiB target and creates 64 MiB and 32 MiB files;
the existing `s1.size() == 2` and 100/50 weight assertions confirm that each
file produced one whole-file range. For `s11`, `length == fileLength`, but
`FileSplit.getFileAffinityKey()` requires `fileLength > length`, so enabling
the flag cannot make this key present and this assertion fails
deterministically. Please make the fixture produce multiple ranges for one file
(or keep this whole-file case negative and add a separate split-file positive
case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
