github-actions[bot] commented on code in PR #66640:
URL: https://github.com/apache/doris/pull/66640#discussion_r3772138436
##########
fe/fe-core/src/test/java/org/apache/doris/qe/VariableMgrTest.java:
##########
@@ -129,6 +129,31 @@ public void testSetGlobalDefault() throws Exception {
Assert.assertEquals(defaultSessionVar.enableProfile(),
VariableMgr.newSessionVariable().enableProfile());
}
+ @Test
+ public void testEnableNereidsDistributePlannerAfterUpgrade() {
+ SessionVariable defaultSessionVariable =
VariableMgr.getDefaultSessionVariable();
+ boolean originalValue =
defaultSessionVariable.isEnableNereidsDistributePlanner();
+ boolean originalEnableSqlCache =
defaultSessionVariable.isEnableSqlCache();
+ boolean originalAnsiBehavior =
GlobalVariable.enable_ansi_query_organization_behavior;
+ boolean originalTypeCoercionBehavior =
GlobalVariable.enableNewTypeCoercionBehavior;
+ int originalVersion = GlobalVariable.variableVersion;
+ try {
+ defaultSessionVariable.setEnableNereidsDistributePlanner(false);
+ GlobalVariable.variableVersion =
GlobalVariable.VARIABLE_VERSION_300;
+
+ VariableMgr.forceUpdateVariables();
+
+
Assertions.assertTrue(VariableMgr.newSessionVariable().isEnableNereidsDistributePlanner());
Review Comment:
The new test does not compile on this branch: this JUnit 4 class imports
`org.junit.Assert`, but `Assertions` is neither imported nor defined in the
package. Please use the existing `Assert.assertTrue` / `Assert.assertEquals`
calls (or explicitly import JUnit Jupiter's `Assertions`) so FE test
compilation can proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
