github-actions[bot] commented on code in PR #66570:
URL: https://github.com/apache/doris/pull/66570#discussion_r3771872490
##########
fe/fe-core/src/test/java/org/apache/doris/qe/LocalExchangePlannerTest.java:
##########
@@ -163,6 +169,106 @@ public void testAggWithoutKeyTwoPhase() throws Exception {
olapScan("t1")))))));
}
Review Comment:
[P2] Add a result-bearing regression for this wrong-result path
This test only runs `EXPLAIN`, and `runBeforeAll()` leaves both tables
empty. The existing result-bearing local-shuffle regressions do not combine
`agg_phase=1` with `enable_broadcast_join_force_passthrough=true`, so the
reported task-count-multiplied result could recur while every new test still
passes. Please add a regression with two rows sharing the distinct key, pin
`batch_size=1` and four local tasks so PASSTHROUGH sends separate blocks to
different channels, enable these exact trigger settings, and assert the literal
correct result or compare it with a one-task/BE-planned baseline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
