HappenLee commented on code in PR #65837:
URL: https://github.com/apache/doris/pull/65837#discussion_r3766016472
##########
be/src/exec/operator/olap_scan_operator.cpp:
##########
@@ -1109,10 +1113,43 @@ void OlapScanLocalState::set_scan_ranges(RuntimeState*
state,
for (auto& scan_range : scan_ranges) {
DCHECK(scan_range.scan_range.__isset.palo_scan_range);
_scan_ranges.emplace_back(new
TPaloScanRange(scan_range.scan_range.palo_scan_range));
+ const auto& palo_scan_range = scan_range.scan_range.palo_scan_range;
+ if (palo_scan_range.__isset.bucket_seq ||
palo_scan_range.__isset.bucket_num) {
+ DORIS_CHECK(palo_scan_range.__isset.bucket_seq);
+ DORIS_CHECK(palo_scan_range.__isset.bucket_num);
+ _rf_bucket_prune_ranges.emplace_back(palo_scan_range.tablet_id,
+ palo_scan_range.bucket_seq,
+ palo_scan_range.bucket_num);
+ }
COUNTER_UPDATE(_tablet_counter, 1);
}
}
+Status OlapScanLocalState::_on_runtime_filter_update(const VExprContextSPtrs&
new_conjuncts) {
+ RETURN_IF_ERROR(Base::_on_runtime_filter_update(new_conjuncts));
+ if (!state()->query_options().enable_runtime_filter_bucket_prune ||
+ _rf_bucket_prune_ranges.empty()) {
+ return Status::OK();
+ }
+
+ int64_t newly_pruned = 0;
+ RETURN_IF_ERROR(_rf_bucket_pruner.prune_by_runtime_filters(
Review Comment:
这里使用dcheck完全没问题，这里有问题，是应该抛异常报错的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
