github-actions[bot] commented on code in PR #66620: URL: https://github.com/apache/doris/pull/66620#discussion_r3765244523
########## be/src/format/table/iceberg/arrow_schema_util.cpp: ########## @@ -17,6 +17,7 @@ #include "format/table/iceberg/arrow_schema_util.h" +#include <arrow/extension/parquet_variant.h> Review Comment: [P2] Honor or reject the Variant shredding setting This branch always builds the unshredded `metadata`/`value` storage, but FE now admits Variant writes to any v3 Parquet table, including one with `write.parquet.shred-variants=true`. The table sink does not carry that property, so INSERT and data-producing UPDATE/MERGE silently write unshredded files despite the Iceberg setting; all new write regressions avoid the path by forcing it to `false`. Please either propagate and implement the requested shredding (including its inference-buffer setting), or reject Variant writes when the effective property is true until that encoding is supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
