HappenLee commented on code in PR #66648:
URL: https://github.com/apache/doris/pull/66648#discussion_r3756984993
##########
be/src/storage/iterator/olap_data_convertor.h:
##########
@@ -301,36 +303,42 @@ class OlapBlockDataConvertor {
}
Status convert_to_olap() override {
- typename PrimitiveTypeTraits<T>::ColumnType* column_data = nullptr;
+ using ColumnType = typename PrimitiveTypeTraits<T>::ColumnType;
+
+ const ColumnType* column_data = nullptr;
if (_nullmap) {
- auto nullable_column =
+ const auto* nullable_column =
assert_cast<const
ColumnNullable*>(_typed_column.column.get());
- _mutable_column =
std::move(nullable_column->get_nested_column()).mutate();
- column_data = assert_cast<typename
PrimitiveTypeTraits<T>::ColumnType*>(
- _mutable_column.get());
+ column_data = assert_cast<const
ColumnType*>(&nullable_column->get_nested_column());
} else {
- _mutable_column = std::move(*_typed_column.column).mutate();
- column_data = assert_cast<typename
PrimitiveTypeTraits<T>::ColumnType*>(
- _mutable_column.get());
+ column_data = assert_cast<const
ColumnType*>(_typed_column.column.get());
}
assert(column_data);
- _values = (typename
PrimitiveTypeTraits<T>::CppType*)(column_data->get_data().data()) +
- _row_pos;
+ _values = column_data->get_data().data() + _row_pos;
if constexpr (T == TYPE_FLOAT || T == TYPE_DOUBLE) {
- for (size_t i = 0; i < _num_rows; ++i) {
- if (std::isnan(_values[i])) {
- _values[i] = std::numeric_limits<
- typename
PrimitiveTypeTraits<T>::CppType>::quiet_NaN();
+ _converted_values.clear();
Review Comment:
添加一个注释，把这里转换的来龙去脉讲清楚
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
