AntiTopQuark commented on code in PR #66191:
URL: https://github.com/apache/doris/pull/66191#discussion_r3755731289
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java:
##########
@@ -104,6 +104,10 @@ public TabletHealth() {
@SerializedName(value = "id")
protected long id;
+ // Cross-link for a split base/row-binlog tablet pair. Legacy images do not
+ // contain this field and therefore keep the non-positive "not aligned"
value.
+ @SerializedName(value = "ati")
+ protected long alignedTabletId = -1L;
Review Comment:
Thanks, this has been addressed in the latest revision (`d0182ef9ef`) after
rebasing on #65810.
This PR no longer introduces `alignedTabletId` / `ati`, separate row-binlog
index states, or any other persisted tablet-pair representation. The locality,
checker, and scheduler paths now use #65810’s canonical directional links:
- companion -> base: `getRowBinlogBaseTabletId()`
- base -> companion: `getRowBinlogTabletId()`
The companion index is identified by `MaterializedIndex.isRowBinlog()` with
`IndexState.NORMAL`. The current `Tablet.java` diff does not add any pairing
field; it only adds the `binlogMissing` replica filter. No new Gson or wire
representation is introduced by this PR.
The Gson and locality tests were also updated for the directional fields and
for old JSON without those optional fields. Since `alignedTabletId` never
landed in the community branch and no deployed image was written with that
model, there is no metadata migration to perform. If a declared row-binlog
companion has missing or inconsistent directional links, it is treated as
invalid metadata rather than falling back to a second representation.
FE unit tests have not been run locally yet; only static source, conflict,
and history checks were completed. Could you please take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
