hulincup commented on PR #66416:
URL: https://github.com/apache/doris/pull/66416#issuecomment-5211181646
Thanks — logged in as guest and pulled the failing tests. Triaging:
**My new `test_point_query_list_partition` fails in all three regression
builds.** The `explain { contains "SHORT-CIRCUIT" }` step passes, but the
actual `SELECT` throws `NullPointerException: Cannot invoke "Expr.getType()"
because "expr" is null`.
Root-cause trace (static): the NPE is thrown at `ExprToThriftVisitor:114`
(`msg.type = expr.getType()`, param name `expr` matches the NPE), called from
`PointQueryExecutor.addKeyTuples:237` `treeToThrift(literalExpr)` where
`literalExpr` is null — returned by `columnExpr.get(column.getName())` at line
219 when a key column name has no matching entry in the conjunct map built at
lines 207-213 from `scanNode.getConjuncts()` slot column names.
My `useNereidsPrune` change lets the direct point query pass the
single-tablet checkState (where the original IllegalStateException was thrown)
and reach `addKeyTuples`, surfacing a pre-existing null-handling gap.
`distributionPrune` itself doesn't touch conjuncts, only tablet selection.
I've pushed a defensive check (commit 7e5ec29) that throws a diagnostic
TException — naming the unmatched key column and the available conjunct columns
— instead of the NPE, so the next run reveals the exact column-name mismatch. I
still need to confirm why the conjunct slot columnName doesn't match the base
schema column name on this LIST-partitioned table, then fix that.
**Existing `point_query_p0` tests fail differently** —
`test_point_query_partition` / `_ck` throw `IllegalStateException: Check tag
'point_select' failed` at the prepared-statement `qe_point_select` step, a path
I explicitly did not change. Likely master flakes; will confirm against master.
**The rest are unrelated** — search_score_cache, compaction, eager_agg,
eliminate_inner, temp_table, multi_leading, mow_compact, performance (deploy
step). Pre-existing in their own areas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
