github-actions[bot] commented on code in PR #15642:
URL: https://github.com/apache/doris/pull/15642#discussion_r1073339625
##########
be/src/olap/rowset/segment_v2/column_reader.h:
##########
@@ -417,6 +417,60 @@ class ArrayFileColumnIterator final : public
ColumnIterator {
vectorized::ColumnArray::ColumnOffsets&
column_offsets);
};
+class RowIdColumnIterator : public ColumnIterator {
+public:
+ RowIdColumnIterator() = delete;
+ RowIdColumnIterator(int32_t tid, RowsetId rid, int32_t segid)
+ : _tablet_id(tid), _rowset_id(rid), _segment_id(segid) {}
+
+ Status seek_to_first() override {
+ _current_rowid = 0;
+ return Status::OK();
+ }
+
+ Status seek_to_ordinal(ordinal_t ord_idx) override {
+ _current_rowid = ord_idx;
+ return Status::OK();
+ }
+
+ Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) {
+ bool has_null;
+ return next_batch(n, dst, &has_null);
+ }
+
+ Status next_batch(size_t* n, ColumnBlockView* dst, bool* has_null)
override {
Review Comment:
warning: unknown type name 'ColumnBlockView' [clang-diagnostic-error]
```cpp
Status next_batch(size_t* n, ColumnBlockView* dst, bool* has_null)
override {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
