u70b3 commented on issue #66079: URL: https://github.com/apache/doris/issues/66079#issuecomment-5178943441
Ah, my mistake — I searched for related PRs before starting but missed #66080. Great to see this already in progress, and nice call using `getTableNamesWithLock()` over the OrEmpty variant — swallowing name-conflict/init failures into an empty result would have been a subtle regression vs. the old path. Since #66080 currently has manual testing only, I'd like to contribute the unit tests I wrote while implementing the same change independently (6 cases: names-only fast path never calls `getTables()`, LIKE filter, SHOW privilege filter, and SHOW FULL TABLES / SHOW VIEWS / internal-catalog paths unchanged). I'll open a PR against your branch with them shortly — feel free to fold them into #66080 if you like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
