github-actions[bot] commented on code in PR #65330:
URL: https://github.com/apache/doris/pull/65330#discussion_r3708938022


##########
contrib/datasketches-cpp:
##########
@@ -1 +0,0 @@
-Subproject commit de8553ba372e618382c2e7b44b0ffc9422b9458c

Review Comment:
   [P1] Restore the five pinned dependency gitlinks. This PR deletes 
`apache-orc`, `clucene`, `datasketches-cpp`, `faiss`, and `openblas`, but 
`.gitmodules`, `build.sh`, `run-be-ut.sh`, and CMake still consume those paths. 
On this head `git submodule update` cannot resolve them; the fallback gets an 
empty SHA from `git ls-tree` and downloads moving branch archives instead. This 
is already material for DataSketches: the deleted pin is 5.2.0, while current 
`master` is a 5.3 development revision, so a clean build compiles dependency 
code outside the reviewed PR. Please restore all five gitlinks (or replace them 
with explicitly verified immutable revisions).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to