github-actions[bot] commented on code in PR #66154:
URL: https://github.com/apache/doris/pull/66154#discussion_r3701157190
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -231,6 +231,11 @@ public class Config extends ConfigBase {
"The log roll size of BDBJE. When the number of log entries
exceeds this value, the log will be rolled"})
public static int edit_log_roll_num = 50000;
Review Comment:
Preserve the existing interval key across upgrades.
`cloud_checkpoint_image_stale_threshold_seconds` is already a mutable
operator-facing setting in the base, but this replacement provides no alias or
migration. `ConfigBase` warns and ignores removed startup keys and rejects them
for runtime mutation, so an upgraded FE with the old value `0` enables hourly
rolls/checkpoints from the new default, while a custom `60` becomes `3600`;
promotion to that FE can change behavior without an operator config change.
Please retain the old name for the new mechanism or provide a deprecated
compatibility alias with explicit precedence and migration coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
