github-actions[bot] commented on code in PR #66343:
URL: https://github.com/apache/doris/pull/66343#discussion_r3694579675
##########
be/test/format_v2/parquet/parquet_scan_test.cpp:
##########
@@ -3125,7 +3125,7 @@ TEST_F(ParquetScanTest,
DefinitionOnlyDatePredicatePreservesConversionSemantics)
}
}
-TEST_F(ParquetScanTest,
PredicateOnlyDictionaryRangeSkipsTypedValueMaterialization) {
+TEST_F(ParquetScanTest,
PredicateOnlyNonStringDictionaryRangeUsesDecodedValues) {
Review Comment:
The renamed INT/BIGINT tests only invert Profile expectations; their row
counts and values already pass on the parent, so they do not reproduce the
stated logical-domain correctness bug. Please add a reachable non-identity case
(for example mapper/schema evolution or date/decimal/unsigned/fixed-binary)
where the old dictionary-ID path returns wrong rows or the wrong error, and
assert parity with V1 or the decoded fallback. Otherwise this blanket
non-string restriction has no result-level regression proving why the
performance path must be disabled.
##########
be/src/format_v2/parquet/parquet_scan.cpp:
##########
@@ -162,6 +162,11 @@ bool supports_row_level_dictionary_filter(const
ParquetColumnSchema& column_sche
column_schema.max_repetition_level > 0) {
return false;
}
+ if
(!is_string_type(remove_nullable(column_schema.type)->get_primitive_type())) {
Review Comment:
This guard rejects every primitive handled by
`get_typed_dictionary_raw_values()` before `build_dictionary_entry_filter()`
runs. As a result, `TYPED_FIXED_WIDTH`, the fixed-width fused projection path,
`DictFilterTypedCompareColumns`, and `DictionaryPredicateFusedProjectedRows`
now have no reachable producer, while the design metrics table and INT64
benchmark matrix still advertise them. Please remove/update the dead machinery
and counters, or retain a semantics-safe reachable producer, so Profiles and
benchmark coverage describe executable behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
