luwei16 commented on code in PR #65810:
URL: https://github.com/apache/doris/pull/65810#discussion_r3690231158
##########
be/src/storage/compaction/compaction.cpp:
##########
@@ -603,15 +605,18 @@ bool CompactionMixin::handle_ordered_data_compaction() {
}
if (is_binlog_compaction) {
+ DCHECK(!_input_rowsets.empty()) << "tablet=" << _tablet->tablet_id();
+ auto compaction_level =
_input_rowsets.front()->rowset_meta()->compaction_level();
bool can_quick_merge_binlog =
- compaction_level() ==
BinlogCompactionPolicy::kBinlogCompactionMaxLevel - 1 &&
+ compaction_level ==
+
BinlogCumulativeCompactionPolicy::kBinlogCompactionMaxLevel - 1 &&
_input_rowsets.size() >= 2 &&
_input_rowsets[0]->start_version() == 0;
if (!can_quick_merge_binlog) {
return false;
}
// Binlog quick merge at LMax is a special meta/link compaction path
selected by
- // BinlogCompactionPolicy. It does not require the whole input to
satisfy the normal
+ // BinlogCumulativeCompactionPolicy. It does not require the whole
input to satisfy the normal
// ordered-data tidy check, but the output rowset built by
do_compact_ordered_rowsets()
// is still NONOVERLAPPING.
auto st = do_compact_ordered_rowsets();
Review Comment:
Row-binlog L2 rowsets may have overlapping key ranges. The old
implementation marked quick-merge output as OVERLAPPING, but this path always
sets NONOVERLAPPING. Should we preserve OVERLAPPING for binlog quick compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
