deardeng opened a new pull request, #66281:
URL: https://github.com/apache/doris/pull/66281
Problem Summary: In Cloud mode, a per-query SET_VAR(cloud_cluster=...)
temporarily changes the session variable used by query scheduling. StmtExecutor
reverted this value before AuditLogHelper built the audit event, so
ComputeGroupName and related per-Compute-Group query, error, and latency
metrics were attributed to the session's original Compute Group even though the
query ran on the hinted group. Preserve the query-scoped effective Compute
Group before reverting SET_VAR and use it for both audit events and metrics,
with fallback to the existing session resolution path.
### Release note
Fix ComputeGroupName in FE audit logs and Compute Group query metrics for
per-query cloud_cluster/compute_group hints.
### Check List (For Author)
- Test: ./build.sh --fe -j 2; ./run-fe-ut.sh --run
org.apache.doris.qe.AuditLogHelperTest; mvn checkstyle:check -pl fe-core; git
diff --check. The Cloud regression case was added but not run because this
worktree has no running Doris cluster.
- Regression test / Unit Test / Manual test / No need to test (with
reason)
- Behavior changed: Yes (audit and metric attribution corrected)
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
